Security Fixes: Unauthenticated PDF access, Admin Password IDOR, and Private Settings BypassDev#1442
Open
SouvickSarkar20 wants to merge 5 commits into
Open
Security Fixes: Unauthenticated PDF access, Admin Password IDOR, and Private Settings BypassDev#1442SouvickSarkar20 wants to merge 5 commits into
SouvickSarkar20 wants to merge 5 commits into
Conversation
Update master
Removed duplicate reporting process for vulnerabilities via Huntr.dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses three security vulnerabilities:
Unauthenticated PDF Download: Added authentication middleware and hardened queries to prevent unauthorized financial data access.
Admin Password IDOR: Fixed a vulnerability where admins could change other admins' passwords via IDOR by tying updates to the authenticated session ID.
Private Settings Bypass: Enforced isPrivate: false filters across all settings read/search/list endpoints to prevent sensitive credential leakage.